This is my personal gitlab instance. Feel free to browse my stuff: https://gitlab.greeson.xyz/users/highsaltlevels/projects

Tons of Tests

David Greeson requested to merge tests into master

Created by: HighSaltLevels

Version 2.5.4

A version bump was needed because there's a few minor bug fixes in here found due to testing 🔆

Testing

There is now coverage for everything except for __main__.py and the while True: coroutines that check for polls and reminders.

Before:

Name                    Stmts   Miss  Cover   Missing
-----------------------------------------------------
saltbot/__init__.py         0      0   100%
saltbot/__main__.py         5      5     0%   4-11
saltbot/api.py             23      0   100%
saltbot/commands.py       188    188     0%   3-373
saltbot/controller.py      41     41     0%   2-63
saltbot/giphy.py           20      0   100%
saltbot/logger.py          15     15     0%   4-26
saltbot/poll.py            72     24    67%   92-124
saltbot/reminder.py       125    125     0%   4-221
saltbot/timelength.py      15      0   100%
saltbot/version.py          1      1     0%   3
saltbot/youtube.py         20      0   100%
-----------------------------------------------------
TOTAL                     525    399    24%

After

Name                    Stmts   Miss  Cover   Missing
-----------------------------------------------------
saltbot/__init__.py         0      0   100%
saltbot/__main__.py         5      5     0%   4-11
saltbot/api.py             24      0   100%
saltbot/commands.py       165      0   100%
saltbot/controller.py      43      0   100%
saltbot/giphy.py           22      0   100%
saltbot/logger.py          15      0   100%
saltbot/poll.py            73     23    68%   93-124
saltbot/reminder.py       127     14    89%   200-216
saltbot/timelength.py      17      0   100%
saltbot/version.py          1      0   100%
saltbot/youtube.py         21      0   100%
-----------------------------------------------------
TOTAL                     513     42    92%

Bug Fixes:

  • Fixed passing of args in Giphy and consolidated Youtube call
  • Added 'years'
  • Fixed missing item from tuple return and removed unnecessary exception checking
  • Fixed typo in reminder error message

Changes:

  • Changed naming in deploy workflow to more accurately reflect the job
  • Run on ubuntu 18.04 with python3.8
  • Added pytest-asyncio to requirements
  • Used n for nut instead of u
  • Removed the anime function for now. It was broken to begin with (will add back when it's working)
  • Run workflow only on pull requests

Merge request reports