Bug fixes and Enhancements
Created by: HighSaltLevels
What/Why
Several bug fixes from my last set of playthroughs along with some nice QoL enhancements for my own tooling. I reverted all the custom qt styling because I honestly don't think it looks any better. It's in my git history if I ever want to try again.
Changes Broken Down
Bug Fixes
- Allow anyone to use prf weapons: I've done this for some games, but FE8 still had prf assigned to a lot of items. This should clear that up.
- Fix bug where some monsters in FE8 can get a dragonstone
- Characters who's bases depend on items are now buffed: certain characters (typically final bosses and dragons) gain most of their stats from their held items or their class. Now I just set their character base hp stat to 40 and their other bases to 20.
- Fix bug where L'Arachel's state was not right: Missed pointer on my part. I was setting the byte after the one I needed to set by accident.
- Fix bug where Myrrh is not randomized: Still not sure if this fixes this. But I'm trying to fix this issue. I can't find anywhere else where she is defined so I can set her class.
- Fix bug where Sonia and Limstella were randomized to an unpromoted class
- Fix bug where Vaida's spear could randomly appear
- Fix bug where Pascal's and Kenneth's weapon levels were wrong
Project Tooling
- Use json.dumps for better formatted output: Cleans up the output of toolling.
-
Run black and ruff on tools: Ruff is a faster linter than pylint, and I need to use it and
blackon my tooling too for consistency.
Other
- Update FE7.sav to be compatible with retroarch: I have no idea what version of vba I originally generated this file in, but it's definitely not compatible with most versions. This one seems to satisfy any vba I throw it at though.
- Add list of strange behavior: I felt like I needed a list of behavior of things that I can't or do not want to change. This way, I don't have to investigate strange behavior a second time.
- Upgrade all 3rd party and 4th party packages
- Bundle the FE7 save file into the binary: Previously, I required the save file to exist on disk, but now, I just bundle it into the binary so that no file is required to exist on the user's computer.
- Revert the QT stylesheets: I thought the custom stylesheets don't look as good as default. I'll keep using the default style for now.
- Add more known bugs